IRC channel logs


back to list of logs

***Server sets mode: +nt
***Server sets mode: +nt
<damo22>youpi: I want to make sure you noticed that my most recent x4 patchset is the one to review, it supercedes all the other ones
<youpi>I applied most of it already
<damo22>i did some more testing, im not sure why but i get some killall5 cant read from stat when trying to reboot and it blocks the clean shutdown
<damo22>do i need to mark proc as important somewhere?
<youpi>not mark proc as important, but tell proc that your translators are important
<damo22>i have a feeling the dosync_handle is not doing anything because it comes from the wrong bucket, i think libmachdev is supposed to manage the control port
<damo22>for example, rumpdisk has a struct block_device that has a port_info and a bunch of struct members that gets registered in device_open
<damo22>should i be doing that for pci-arbiter too?
<damo22>i will try to fix it tomorrow, i need to sleep now
***janneke_ is now known as janneke
<youpi>damo22: dosync_handle shouldn't be getting called before the very end of the shutdown
<youpi>if it is getting called, it means the translator wasn't setting itself as important indeed
<youpi>in pci-arbiter you don'tneed to invent something like rumpdisk's struct block_device etc., you are already returning a port that libnetfs manages
<youpi>and pci_device_shutdown already properly calls netfs_shutdown, so that'll be fine