IRC channel logs

2020-01-03.log

back to list of logs

<lloda>hi guilers, happy new year
<lloda>wingo: no blockers really
<lloda>the truncation thing but it's not an obvious fix I guess
<lloda>would like to get this patch in http://git.savannah.gnu.org/cgit/guile.git/commit/?h=wip-exception-truncate&id=5b0075651536784ae9694e5e14c808c3f060c0e9
<lloda>I sent it to the list before xmas
<wingo>lloda: i think we should fix the truncation thing but afaiu it can also be fixed during 3.0
<wingo>for the vector-fill! thing, sgtm. can you please declare scm_vector_fill_partial_x as static and use SCM_DEFINE_STATIC in the definition
<wingo>sneek: later tell jonsger i think you might be deleting the ".version" file from the tarball
<sneek>Will do.
<wingo>sneek: later tell civodul maybe we can add a third option to GUILE_INSTALL_LOCALE, to install without warnings, and make that option the default
<sneek>Will do.
<lloda>wingo: you mean SCM_INTERNAL? I don't see SCM_DEFINE_STATIC anywhere
<wingo>ah indeed
<wingo>but not SCM_INTERNAL
*wingo looks
<wingo>we need this: http://git.savannah.gnu.org/cgit/guile-gnome.git/tree/glib/gnome/gobject/private.h#n31
<wingo>can you add it to gsubr.h ? :)
<wingo>otherwise you can land and i can fix up
<lloda>wingo: let me give it a shot
<lloda>will check back with you
*jonsger found another bug
<wingo>what kind? :)
<lloda>wingo: #1 http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=b8e7a73ea0a123a36f5c0a6d0918ba4b93e09c08
<lloda>#2 http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=cb24c0614d146a88b8ce1ab86ea79bc22ca7f4c9
<lloda>lmk
<wingo>lloda: it was broken for 1-dimensional arrays before?
<wingo>i agree with the breaking change fwiw, but it needs a NEWS entry
<lloda>yes, b/c inc was used wrong
<wingo>lgtm otherwise
<wingo>great
<lloda>I'll add the NEWS entry np
<wingo>thumbs up
<jonsger>wingo: build failure on 32bit. It's already on bug-guile :P
<sneek>Welcome back jonsger, you have 1 message.
<sneek>jonsger, wingo says: i think you might be deleting the ".version" file from the tarball
<jonsger>ah. Never saw that file. It says still 2.9.1-... :P
<lloda>wingo: pushed with the NEWS
<lloda>I've messed the whitespace again :-( I've repushed
<jonsger>version.test is now green :)
<wingo>jonsger: it gets generated as part of tarball releases
<wingo>or from git describe if you have a git checkout
<wingo>evidently you have a git checkout but no tags maybe ?
<jonsger>wingo: that one alpha.gnu.org/gnu/guile/guile-2.9.8.tar.xz has 2.9.1 in the .version file
<wingo>that's exciting!
<wingo>i wonder how that happened
***ng0_ is now known as ng0
*civodul found the autoload problem that prevents Guix from building with 2.9.7+ \o/
<wingo>yay :)
<mwette>sweet
***sneek_ is now known as sneek