IRC channel logs

2024-12-27.log

back to list of logs

<fossy>Googulator: no, https://github.com/fosslinux/live-bootstrap/pull/484 i closed the PR because it wasn't helpful at the time, but I could readd the functionality - the functionality worked
<fossy>stikonas what do you think?
<fossy> https://github.com/fosslinux/live-bootstrap/pull/489: any more comments on this?
<stikonas>fossy, Googulator: yes, we can readd optional builds in LB
<stikonas>(sorry, I am not that much online these days until the beginning of the next year)
<stikonas>fossy: if possible, I would like to review #489 it a bit more
<stikonas>but I probably won't have time this year
<stikonas>so if you want to merge it, ask Googulator for comments
<stikonas>one thing I didn't 100% like (though it's not a dealbreaker) is that most patches everywhere are applied with -p1 cause that's what you get out of tools such as "git diff", etc...
<stikonas>so we always need to tweak them when adding to live-bootstrap
<stikonas>but oh well, it's not the end of the world