IRC channel logs
2025-03-18.log
back to list of logs
<rlb>civodul, wingo: wondered if we could enable -Werror=array-bounds by default? That would have caught the getsockopt overrun (recent bug). In any case, I'll handle the patch tomorrow. <rlb>Looks like at least linux getsockopt() doesn't return EINVAL there either. Not sure atm whether that's a bug or intentional. <civodul>rlb: with appropriate configure check, and if it can cope with existing code, that sounds like a good idea <rlb>OK, it seems to compile everything just fine, but I'll double-check. And can check clang too if we support it. <rlb>Also, I forget if sneek sends later tell privately. If not, would it be plausible to mark the 00-repl-server.test inter-protocol test as unresolved for now or XFAIL? <dsmith>rlb, The bot does not send private messages for later tell <rlb>civodul: if everything checks out, I add the -Werror=array-bounds. Can always back off, or move it to some "strict" configure option if it causes trouble somewhere relevant. <civodul>rlb: sure, with a feature check in ./configure, it sounds harmless to me <rlb>(Not the same thing, but I was mostly remembering cases (elsewhere) where -Werror couldn't be the default because it created false positive on some arch/compiler combinations too often.)